netdev - Re: [PATCH net-next] bnxt_en: Fix allocation of zero statistics block size regression.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DDE3237E-CABF-4417-AB26-3623A7CEF9DE@gmail.com>
Date:   Fri, 23 Aug 2019 07:24:34 -0700
From:   "Jonathan Lemon" <jonathan.lemon@...il.com>
To:     "Michael Chan" <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        kernel-team <kernel-team@...com>
Subject: Re: [PATCH net-next] bnxt_en: Fix allocation of zero statistics block
 size regression.



On 22 Aug 2019, at 22:51, Michael Chan wrote:

> Recent commit added logic to determine the appropriate statistics 
> block
> size to allocate and the size is stored in bp->hw_ring_stats_size.  
> But
> if the firmware spec is older than 1.6.0, it is 0 and not initialized.
> This causes the allocation to fail with size 0 and bnxt_open() to
> abort.  Fix it by always initializing bp->hw_ring_stats_size to the
> legacy default size value.
>
> Fixes: 4e7485066373 ("bnxt_en: Allocate the larger per-ring statistics 
> block for 57500 chips.")
> Reported-by: Jonathan Lemon <jonathan.lemon@...il.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Tested-by: Jonathan Lemon <jonathan.lemon@...il.com>
Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>

Thanks, Michael!
-- 
Jonathan