netdev - Re: BUG: bnxt_en driver fails to initialize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLinyPbrxFAdCC442FWoQ9woGeEMm-f+G1eHre5s7_q-DOQ@mail.gmail.com>
Date:   Thu, 22 Aug 2019 20:22:25 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>, Kernel Team <kernel-team@...com>
Subject: Re: BUG: bnxt_en driver fails to initialize

On Thu, Aug 22, 2019 at 8:03 PM Jonathan Lemon <jonathan.lemon@...il.com> wrote:
>
> On a recent net-next 932630fa902878f4c8c50d0b1260eeb9de16b0a4,
> installing the build on a box which has a Broadcom card with
> the 20.1 firmware, the driver refuses to initialize.  I tracked
> this down to:
>
>         static int bnxt_alloc_stats(struct bnxt *bp)
>         ...
>                  cpr->hw_stats = dma_alloc_coherent(&pdev->dev, size,
>                                                     &cpr->hw_stats_map,
>                                                     GFP_KERNEL);
>                  if (!cpr->hw_stats)
>                          return -ENOMEM;
>
> Where size == 0, so obviously it returns NULL, and -ENOMEM.

Thanks for the report.  I will send a patch to fix this later tonight.

>
> The same build, when installed on different box with the
> 20.6.167.0 firmware, works fine.  Details below.
>
>