netdev - Re: [PATCH v4 net-next 4/7] ip6tlvs: Registration of TLV handlers and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190823.151657.2068961230800142712.davem@davemloft.net>
Date:   Fri, 23 Aug 2019 15:16:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     netdev@...r.kernel.org, tom@...ntonium.net
Subject: Re: [PATCH v4 net-next 4/7] ip6tlvs: Registration of TLV handlers
 and parameters

From: Tom Herbert <tom@...bertland.com>
Date: Fri, 23 Aug 2019 12:14:00 -0700

>  					int off, enum ipeh_parse_errors error))
>  {
>  	const unsigned char *nh = skb_network_header(skb);
> -	const struct tlvtype_proc *curr;
> +	const struct tlv_proc *curr;
>  	bool disallow_unknowns = false;
>  	int tlv_count = 0;
>  	int padlen = 0;

Please retain the reverse christmas tree ordering here.