netdev - Re: [PATCH][next] mac80211: minstrel_ht: fix infinite loop because supported is not being shifted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <accffa31-b954-0dcd-6c42-44fad63b96e2@nbd.name>
Date:   Fri, 23 Aug 2019 13:07:37 +0200
From:   Felix Fietkau <nbd@....name>
To:     Colin King <colin.king@...onical.com>,
        Johannes Berg <johannes@...solutions.net>,
        "David S . Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] mac80211: minstrel_ht: fix infinite loop because
 supported is not being shifted

On 2019-08-22 14:20, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the for-loop will spin forever if variable supported is
> non-zero because supported is never changed.  Fix this by adding in
> the missing right shift of supported.
> 
> Addresses-Coverity: ("Infinite loop")
> Fixes: 48cb39522a9d ("mac80211: minstrel_ht: improve rate probing for devices with static fallback")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: Felix Fietkau <nbd@....name>

Thanks,

- Felix