netdev - Re: [net-next 07/14] ice: Rename ethtool private flag for lldp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190824.164726.357731088137490877.davem@davemloft.net>
Date:   Sat, 24 Aug 2019 16:47:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     jeffrey.t.kirsher@...el.com, david.m.ertman@...el.com,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        andrewx.bowers@...el.com
Subject: Re: [net-next 07/14] ice: Rename ethtool private flag for lldp

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 23 Aug 2019 18:31:11 -0700

> On Fri, 23 Aug 2019 16:37:43 -0700, Jeff Kirsher wrote:
>> From: Dave Ertman <david.m.ertman@...el.com>
>> 
>> The current flag name of "enable-fw-lldp" is a bit cumbersome.
>> 
>> Change priv-flag name to "fw-lldp-agent" with a value of on or
>> off.  This is more straight-forward in meaning.
>> 
>> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
>> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Just flagging this for Dave, it was introduced in v5.2 by:

So should we backport the rename into 'net'?  Is this a bug fix or just
making life easier for people?