netdev - Re: [PATCH net] nexthop: Fix nexthop_num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190825.143246.1565839919556239720.davem@davemloft.net>
Date:   Sun, 25 Aug 2019 14:32:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, sharpd@...ulusnetworks.com,
        dsahern@...il.com
Subject: Re: [PATCH net] nexthop: Fix nexthop_num_path for blackhole
 nexthops

From: David Ahern <dsahern@...nel.org>
Date: Sun, 25 Aug 2019 07:47:30 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Donald reported this sequence:
>   ip next add id 1 blackhole
>   ip next add id 2 blackhole
>   ip ro add 1.1.1.1/32 nhid 1
>   ip ro add 1.1.1.2/32 nhid 2
> 
> would cause a crash. Backtrace is:
 ...
> fib_dump_info incorrectly has nhs = 0 for blackhole nexthops, so it
> believes the nexthop object is a multipath group (nhs != 1) and ends
> up down the nexthop_mpath_fill_node() path which is wrong for a
> blackhole.
> 
> The blackhole check in nexthop_num_path is leftover from early days
> of the blackhole implementation which did not initialize the device.
> In the end the design was simpler (fewer special case checks) to set
> the device to loopback in nh_info, so the check in nexthop_num_path
> should have been removed.
> 
> Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
> Reported-by: Donald Sharp <sharpd@...ulusnetworks.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied, thanks David.