netdev - Re: [PATCH] r8152: Set memory to all 0xFFs on failed reg reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190825.195322.56301632454796863.davem@davemloft.net>
Date:   Sun, 25 Aug 2019 19:53:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pmalani@...omium.org
Cc:     hayeswang@...ltek.com, grundler@...omium.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] r8152: Set memory to all 0xFFs on failed reg reads

From: Prashant Malani <pmalani@...omium.org>
Date: Sat, 24 Aug 2019 01:36:19 -0700

> get_registers() blindly copies the memory written to by the
> usb_control_msg() call even if the underlying urb failed.
> 
> This could lead to junk register values being read by the driver, since
> some indirect callers of get_registers() ignore the return values. One
> example is:
>   ocp_read_dword() ignores the return value of generic_ocp_read(), which
>   calls get_registers().
> 
> So, emulate PCI "Master Abort" behavior by setting the buffer to all
> 0xFFs when usb_control_msg() fails.
> 
> This patch is copied from the r8152 driver (v2.12.0) published by
> Realtek (www.realtek.com).
> 
> Signed-off-by: Prashant Malani <pmalani@...omium.org>

Applied.