netdev - Re: [PATCH net-next v3 01/10] net: sched: protect block offload-related fields with rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190826153948.GB2309@nanopsycho.orion>
Date:   Mon, 26 Aug 2019 17:39:48 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, jakub.kicinski@...ronome.com,
        pablo@...filter.org
Subject: Re: [PATCH net-next v3 01/10] net: sched: protect block
 offload-related fields with rw_semaphore

Mon, Aug 26, 2019 at 03:44:57PM CEST, vladbu@...lanox.com wrote:
>In order to remove dependency on rtnl lock, extend tcf_block with 'cb_lock'
>rwsem and use it to protect flow_block->cb_list and related counters from
>concurrent modification. The lock is taken in read mode for read-only
>traversal of cb_list in tc_setup_cb_call() and write mode in all other
>cases. This approach ensures that:
>
>- cb_list is not changed concurrently while filters is being offloaded on
>  block.
>
>- block->nooffloaddevcnt is checked while holding the lock in read mode,
>  but is only changed by bind/unbind code when holding the cb_lock in write
>  mode to prevent concurrent modification.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>