netdev - Re: [PATCH net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C1DB8ED7-2846-4F05-A084-07B83568D67D@ovn.org>
Date:   Mon, 26 Aug 2019 11:42:10 -0700
From:   Justin Pettit <jpettit@....org>
To:     Pravin Shelar <pshelar@....org>, David Miller <davem@...emloft.net>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Joe Stringer <joe@...d.net.nz>,
        Greg Rose <gvrose8192@...il.com>
Subject: Re: [PATCH net 1/2] openvswitch: Properly set L4 keys on "later" IP
 fragments.


> On Aug 25, 2019, at 1:40 PM, Pravin Shelar <pshelar@....org> wrote:
> 
> Actually I am not sure about this change. caller of this function
> (ovs_ct_execute()) does skb-pull and push of L2 header, calling
> ovs_flow_key_update() is not safe here, it expect skb data to point to
> L2 header.

Thanks for the feedback, Pravin and David.  Greg Rose has a revised version that will address the issues you raised and also make it so that we don't bother re-extracting the L2 headers.  He'll hopefully get that out today once we've done some internal testing on it.

--Justin