netdev - Re: [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190826.140437.926589005439320930.davem@davemloft.net>
Date:   Mon, 26 Aug 2019 14:04:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     marek.behun@....cz, netdev@...r.kernel.org,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com
Subject: Re: [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support
 SERDES on Topaz family

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 26 Aug 2019 17:38:30 +0200

>> +static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
>> +				    phy_interface_t mode, bool allow_over_2500,
>> +				    bool make_cmode_writable)
> 
> I don't like these two parameters. The caller of this function can do
> the check for allow_over_2500 and error out before calling this.
> 
> Is make_cmode_writable something that could be done once at probe and
> then forgotten about? Or is it needed before every write? At least
> move it into the specific port_set_cmode() that requires it.

Please respin this series once these issues are sorted out.

Thanks.