netdev - Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190826181722.GD27244@t480s.localdomain>
Date:   Mon, 26 Aug 2019 18:17:22 -0400
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Marek Behún <marek.behun@....cz>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Marek Behún <marek.behun@....cz>
Subject: Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create
 serdes_get_lane chip operation

Hi Marek,

On Mon, 26 Aug 2019 23:31:52 +0200, Marek Behún <marek.behun@....cz> wrote:
> @@ -635,10 +660,10 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id)
>  	irqreturn_t ret = IRQ_NONE;
>  	u8 cmode = port->cmode;
>  	u16 status;
> -	int lane;
>  	int err;
> +	u8 lane;
>  
> -	lane = mv88e6390x_serdes_get_lane(chip, port->port);
> +	mv88e6xxx_serdes_get_lane(chip, port->port, &lane);

I don't like when errors aren't always checked, but the code was already
like this, so this can be addressed in a follow-up patch:

Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>


Thanks,

	Vivien