netdev - Re: [PATCH bpf-next] selftests/bpf: remove wrong nhoff in flow dissector test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW65rWrY8THLK1gVeH4HN3YS3PeiUvPqDYqT9cOoENQSqA@mail.gmail.com>
Date:   Mon, 26 Aug 2019 15:41:13 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next] selftests/bpf: remove wrong nhoff in flow
 dissector test

On Mon, Aug 26, 2019 at 3:28 PM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> .nhoff = 0 is (correctly) reset to ETH_HLEN on the next line so let's
> drop it.
>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Acked-by: Song Liu <songliubraving@...com>

> ---
>  tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> index 6892b88ae065..d2f4a8262200 100644
> --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> @@ -344,7 +344,6 @@ struct test tests[] = {
>                         .tcp.dest = 8080,
>                 },
>                 .keys = {
> -                       .nhoff = 0,
>                         .nhoff = ETH_HLEN,
>                         .thoff = ETH_HLEN + sizeof(struct iphdr) +
>                                 sizeof(struct iphdr),
> --
> 2.23.0.187.g17f5b7556c-goog
>