netdev - Re: [PATCH net-next 01/14] bnxt_en: Suppress all error messages in hwrm_do_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190825.221507.1465677703637201643.davem@davemloft.net>
Date:   Sun, 25 Aug 2019 22:15:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org, vasundhara-v.volam@...adcom.com,
        jiri@...lanox.com, ray.jui@...adcom.com
Subject: Re: [PATCH net-next 01/14] bnxt_en: Suppress all error messages in
 hwrm_do_send_msg() in silent mode.

From: Michael Chan <michael.chan@...adcom.com>
Date: Sun, 25 Aug 2019 23:54:52 -0400

> If the silent parameter is set, suppress all messages when there is
> no response from firmware.  When polling for firmware to come out of
> reset, no response may be normal and we want to suppress the error
> messages.  Also, don't poll for the firmware DMA response if Bus Master
> is disabled.  This is in preparation for error recovery when firmware
> may be in error or reset state or Bus Master is disabled.
> 
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

The function bnxt_hwrm_do_send_msg() seems to be an interesting mix of return
values, what are the semantics?

It seems to use 0 for success, some error codes, and -1.  Does -1 have special
meaning?

Just curious, and really this unorthodox return value semantic should
be documented into a comment above the function.