netdev - Re: [PATCH net-next v3 3/6] net: dsa: mv88e6xxx: create serdes_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190826142107.092b7f08@nic.cz>
Date:   Mon, 26 Aug 2019 14:21:07 +0200
From:   Marek Behun <marek.behun@....cz>
To:     Vivien Didelot <vivien.didelot@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v3 3/6] net: dsa: mv88e6xxx: create
 serdes_get_lane chip operation

On Sun, 25 Aug 2019 12:12:14 -0400
Vivien Didelot <vivien.didelot@...il.com> wrote:

> In fact you're also relying on -ENODEV, which is what you return here (and in
> other places) instead of 0. So I'm afraid you have to address my comment now...

Vivien, you are right. I returned -ENODEV for Peridot when no lane was
to be on port. It should return 0.
I am sending v4 now with this corrected, and tested on Turris Mox with
combinations Peridot, Topaz and Peridot + Topaz.

Marek