netdev - Re: [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23574.1566910624@warthog.procyon.org.uk>
Date:   Tue, 27 Aug 2019 13:57:04 +0100
From:   David Howells <dhowells@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        marc.dionne@...istor.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up

David Miller <davem@...emloft.net> wrote:

> Once you've removed the entries from the globally visible idle_client_comms
> list, and put them on the local garbage list, they cannot be seen in any way
> by external threads of control outside of this function.

Yeah, I think you're right.  I was thinking that it might race with
rxrpc_discard_expired_client_conns() but that takes the locks too, so it
shouldn't.

David