netdev - Re: [net-next] net: sched: pie: enable timestamp based delay calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <316fdac3-5fa9-35d5-ad74-94072f19c5fc@gmail.com>
Date:   Tue, 27 Aug 2019 17:34:51 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Gautam Ramakrishnan <gautamramk@...il.com>, netdev@...r.kernel.org
Cc:     jhs@...atatu.com, davem@...emloft.net, xiyou.wangcong@...il.com,
        Leslie Monis <lesliemonis@...il.com>,
        "Mohit P . Tahiliani" <tahiliani@...k.edu.in>,
        Dave Taht <dave.taht@...il.com>
Subject: Re: [net-next] net: sched: pie: enable timestamp based delay
 calculation



On 8/27/19 4:19 PM, Gautam Ramakrishnan wrote:
> RFC 8033 suggests an alternative approach to calculate the queue
> delay in PIE by using per packet timestamps. This patch enables the
> PIE implementation to do this.
> 
> The calculation of queue delay is as follows:
> 	qdelay = now - packet_enqueue_time
> 
> To enable the use of timestamps:
> 	modprobe sch_pie use_timestamps=1


No module parameter is accepted these days.

Please add a new attribute instead,
so that pie can be used in both mode on the same host.

For a typical example of attribute addition, please take
a look at commit 48872c11b77271ef9b070bdc50afe6655c4eb9aa
("net_sched: sch_fq: add dctcp-like marking")