netdev - Re: [PATCH net-next v5] sched: Add dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190827.150319.716294283021335199.davem@davemloft.net>
Date:   Tue, 27 Aug 2019 15:03:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olivier.tilmans@...ia-bell-labs.com
Cc:     eric.dumazet@...il.com, stephen@...workplumber.org,
        olga@...isser.org, koen.de_schepper@...ia-bell-labs.com,
        research@...briscoe.net, henrist@...rist.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5] sched: Add dualpi2 qdisc

From: "Tilmans, Olivier (Nokia - BE/Antwerp)" <olivier.tilmans@...ia-bell-labs.com>
Date: Thu, 22 Aug 2019 08:10:48 +0000

> +static inline struct dualpi2_skb_cb *dualpi2_skb_cb(struct sk_buff *skb)

Please do not use the inline keyword in foo.c files, let the compiler decide.

> +static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch)
> +{
> +	struct dualpi2_sched_data *q = qdisc_priv(sch);
> +	struct sk_buff *skb;
> +	int qlen_c, credit_change;

Reverse christmas tree here, please.

> +static void dualpi2_timer(struct timer_list *timer)
> +{
> +	struct dualpi2_sched_data *q = from_timer(q, timer, pi2.timer);
> +	struct Qdisc *sch = q->sch;
> +	spinlock_t *root_lock; /* Lock to access the head of both queues. */

Likewise, and please remove this comment it makes the variable declarations
look odd.