netdev - Re: [PATCH net] xfrm: remove the unnecessary .net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190827070136.GY2879@gauss3.secunet.de>
Date:   Tue, 27 Aug 2019 09:01:36 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     network dev <netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH net] xfrm: remove the unnecessary .net_exit for xfrmi

On Mon, Aug 26, 2019 at 04:25:51PM +0800, Xin Long wrote:
> The xfrm_if(s) on each netns can be deleted when its xfrmi dev is
> deleted. xfrmi dev's removal can happen when:
> 
>   1. Its phydev is being deleted and NETDEV_UNREGISTER event is
>      processed in xfrmi_event() from my last patch.
>   2. netns is being removed and all xfrmi devs will be deleted.
>   3. rtnl_link_unregister(&xfrmi_link_ops) in xfrmi_fini() when
>      xfrm_interface.ko is being unloaded.
> 
> So there's no need to use xfrmi_exit_net() to clean any xfrm_if up.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

We already have a bunch of xfrm interface fixes in the ipsec tree.
Please base this patch onto the ipsec tree and adjust if needed.

Thanks!