lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Aug 2019 17:51:31 +0800 From: maowenan <maowenan@...wei.com> To: <wharms@....de> CC: <saeedm@...lanox.com>, <leon@...nel.org>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies On 2019/8/27 15:24, walter harms wrote: > > > Am 27.08.2019 05:12, schrieb Mao Wenan: >> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found: >> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable': >> en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create' >> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable': >> en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy' >> >> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1 >> ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"), >> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE. >> >> Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent") >> Signed-off-by: Mao Wenan <maowenan@...wei.com> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig >> index 37fef8c..a6a70ce 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig >> @@ -35,6 +35,7 @@ config MLX5_CORE_EN >> depends on IPV6=y || IPV6=n || MLX5_CORE=m > > OT but ... > is that IPV6 needed at all ? can there be something else that yes or no ? If I set IPV6=m, errors are found as below: drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_unload': main.c:(.text+0x275): undefined reference to `mlx5_hv_vhca_cleanup' drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_cleanup_once': main.c:(.text+0x2e8): undefined reference to `mlx5_hv_vhca_destroy' drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_load_one': main.c:(.text+0x23c1): undefined reference to `mlx5_hv_vhca_create' main.c:(.text+0x248f): undefined reference to `mlx5_hv_vhca_init' main.c:(.text+0x25e0): undefined reference to `mlx5_hv_vhca_cleanup > > re, > wh > >> select PAGE_POOL >> select DIMLIB >> + imply PCI_HYPERV_INTERFACE >> default n >> ---help--- >> Ethernet support in Mellanox Technologies ConnectX-4 NIC. > > . >
Powered by blists - more mailing lists