netdev - RE: [PATCH] r8152: Add rx_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18D8C55@RTITMBSVM03.realtek.com.tw>
Date:   Wed, 28 Aug 2019 02:04:20 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Prashant Malani <pmalani@...omium.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "grundler@...omium.org" <grundler@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH] r8152: Add rx_buf_sz field to struct r8152

Prashant Malani [mailto:pmalani@...omium.org]
> Sent: Wednesday, August 28, 2019 2:02 AM
> To: Hayes Wang; davem@...emloft.net
> Cc: grundler@...omium.org; netdev@...r.kernel.org; nic_swsd; Prashant
> Malani
> Subject: [PATCH] r8152: Add rx_buf_sz field to struct r8152
> 
> tp->rx_buf_sz is set according to the specific version of HW being used.
> 
> agg_buf_sz was originally added to support LSO (Large Send Offload) and
> then seems to have been co-opted for LRO (Large Receive Offload). But RX
> large buffer size can be larger than TX large buffer size with newer HW.
> Using larger buffers can result in fewer "large RX packets" processed
> by the rest of the networking stack to reduce RX CPU utilization.
> 
> This patch is copied from the r8152 driver (v2.12.0) published by
> Realtek (www.realtek.com).
> 
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> Reviewed-by: Grant Grundler <grundler@...omium.org>
> ---

It seems as same as the commit ec5791c202ac ("r8152: separate the rx
buffer size").

https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/
commit/?id=ec5791c202aca90c1b3b99dff268a995cf2d6aa1

Best Regards,
Hayes