netdev - Re: [PATCH V3 net 2/2] openvswitch: Clear the L4 portion of the key for "later" fragments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_AVT7CaLHgS7qLhhneaxSO3VToFKMNZkocUnyVOxtPV5A@mail.gmail.com>
Date:   Tue, 27 Aug 2019 17:33:13 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Greg Rose <gvrose8192@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Joe Stringer <joe@...d.net.nz>, Justin Pettit <jpettit@....org>
Subject: Re: [PATCH V3 net 2/2] openvswitch: Clear the L4 portion of the key
 for "later" fragments.

On Tue, Aug 27, 2019 at 7:58 AM Greg Rose <gvrose8192@...il.com> wrote:
>
> From: Justin Pettit <jpettit@....org>
>
> Only the first fragment in a datagram contains the L4 headers.  When the
> Open vSwitch module parses a packet, it always sets the IP protocol
> field in the key, but can only set the L4 fields on the first fragment.
> The original behavior would not clear the L4 portion of the key, so
> garbage values would be sent in the key for "later" fragments.  This
> patch clears the L4 fields in that circumstance to prevent sending those
> garbage values as part of the upcall.
>
> Signed-off-by: Justin Pettit <jpettit@....org>

Acked-by: Pravin B Shelar <pshelar@....org>

Thanks,
Pravin.