netdev - Re: [bpf-next] bpf: fix error check in bpf_tcp_gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6yGV1MbA9MHdOp_5VyvMA3EX7Eew6rNKbYZKSD42m-uQ@mail.gmail.com>
Date:   Wed, 28 Aug 2019 12:15:26 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Petar Penkov <ppenkov.kernel@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Petar Penkov <ppenkov@...gle.com>,
        Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [bpf-next] bpf: fix error check in bpf_tcp_gen_syncookie

On Tue, Aug 27, 2019 at 4:46 PM Petar Penkov <ppenkov.kernel@...il.com> wrote:
>
> From: Petar Penkov <ppenkov@...gle.com>
>
> If a SYN cookie is not issued by tcp_v#_gen_syncookie, then the return
> value will be exactly 0, rather than <= 0. Let's change the check to
> reflect that, especially since mss is an unsigned value and cannot be
> negative.
>
> Fixes: 70d66244317e ("bpf: add bpf_tcp_gen_syncookie helper")
> Reported-by: Stanislav Fomichev <sdf@...gle.com>
> Signed-off-by: Petar Penkov <ppenkov@...gle.com>

Acked-by: Song Liu <songliubraving@...com>