netdev - Re: [PATCH net-next 01/15] MIPS: SGI-IP27: remove ioc3 ethernet init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Aug 2019 20:45:20 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 01/15] MIPS: SGI-IP27: remove ioc3 ethernet init

Hi Thomas,

On Wed, Aug 28, 2019 at 04:03:00PM +0200, Thomas Bogendoerfer wrote:
> Removed not needed disabling of ethernet interrupts in IP27 platform code.
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>

Acked-by: Paul Burton <paul.burton@...s.com>

Thanks,
    Paul

> ---
>  arch/mips/sgi-ip27/ip27-init.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/arch/mips/sgi-ip27/ip27-init.c b/arch/mips/sgi-ip27/ip27-init.c
> index 066b33f50bcc..59d5375c9021 100644
> --- a/arch/mips/sgi-ip27/ip27-init.c
> +++ b/arch/mips/sgi-ip27/ip27-init.c
> @@ -130,17 +130,6 @@ cnodeid_t get_compact_nodeid(void)
>  	return NASID_TO_COMPACT_NODEID(get_nasid());
>  }
>  
> -static inline void ioc3_eth_init(void)
> -{
> -	struct ioc3 *ioc3;
> -	nasid_t nid;
> -
> -	nid = get_nasid();
> -	ioc3 = (struct ioc3 *) KL_CONFIG_CH_CONS_INFO(nid)->memory_base;
> -
> -	ioc3->eier = 0;
> -}
> -
>  extern void ip27_reboot_setup(void);
>  
>  void __init plat_mem_setup(void)
> @@ -182,8 +171,6 @@ void __init plat_mem_setup(void)
>  		panic("Kernel compiled for N mode.");
>  #endif
>  
> -	ioc3_eth_init();
> -
>  	ioport_resource.start = 0;
>  	ioport_resource.end = ~0UL;
>  	set_io_port_base(IO_BASE);
> -- 
> 2.13.7
>