netdev - Re: [PATCH V3 net 2/2] openvswitch: Clear the L4 portion of the key for "later" fragments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190828.145414.252682465710153157.davem@davemloft.net>
Date:   Wed, 28 Aug 2019 14:54:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gvrose8192@...il.com
Cc:     netdev@...r.kernel.org, pshelar@....org, joe@...d.net.nz,
        jpettit@....org
Subject: Re: [PATCH V3 net 2/2] openvswitch: Clear the L4 portion of the
 key for "later" fragments.

From: Greg Rose <gvrose8192@...il.com>
Date: Tue, 27 Aug 2019 07:58:10 -0700

> From: Justin Pettit <jpettit@....org>
> 
> Only the first fragment in a datagram contains the L4 headers.  When the
> Open vSwitch module parses a packet, it always sets the IP protocol
> field in the key, but can only set the L4 fields on the first fragment.
> The original behavior would not clear the L4 portion of the key, so
> garbage values would be sent in the key for "later" fragments.  This
> patch clears the L4 fields in that circumstance to prevent sending those
> garbage values as part of the upcall.
> 
> Signed-off-by: Justin Pettit <jpettit@....org>

Applied.