netdev - Re: [PATCH net] ibmvnic: Do not process reset during or after device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190828.154600.1302004323162882858.davem@davemloft.net>
Date:   Wed, 28 Aug 2019 15:46:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net] ibmvnic: Do not process reset during or after
 device removal

From: Thomas Falcon <tlfalcon@...ux.ibm.com>
Date: Tue, 27 Aug 2019 11:10:04 -0500

> Currently, the ibmvnic driver will not schedule device resets
> if the device is being removed, but does not check the device
> state before the reset is actually processed. This leads to a race
> where a reset is scheduled with a valid device state but is
> processed after the driver has been removed, resulting in an oops.
> 
> Fix this by checking the device state before processing a queued
> reset event.
> 
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Tested-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.ibm.com>

Applied.