netdev - Re: [PATCH net-next] net: phy: force phy suspend when calling phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190828.161713.1379723336745594139.davem@davemloft.net>
Date:   Wed, 28 Aug 2019 16:17:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shenjian15@...wei.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
        forest.zhouchang@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH net-next] net: phy: force phy suspend when calling
 phy_stop

From: Jian Shen <shenjian15@...wei.com>
Date: Wed, 28 Aug 2019 09:34:47 +0800

> Some ethernet drivers may call phy_start() and phy_stop() from
> ndo_open() and ndo_close() respectively.
> 
> When network cable is unconnected, and operate like below:
> step 1: ifconfig ethX up -> ndo_open -> phy_start ->start
> autoneg, and phy is no link.
> step 2: ifconfig ethX down -> ndo_close -> phy_stop -> just stop
> phy state machine.
> 
> This patch forces phy suspend even phydev->link is off.
> 
> Signed-off-by: Jian Shen <shenjian15@...wei.com>

Applied.