netdev - Re: [PATCH net-next 2/2] net/mlx5e: Move local var definition into ifdef block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vbfo908ne4k.fsf@mellanox.com>
Date:   Thu, 29 Aug 2019 16:13:56 +0000
From:   Vlad Buslov <vladbu@...lanox.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:     Vlad Buslov <vladbu@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        tanhuazhong <tanhuazhong@...wei.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: Move local var definition into
 ifdef block


On Thu 29 Aug 2019 at 12:29, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> Hello!
>
> On 28.08.2019 19:41, Vlad Buslov wrote:
>
>> New local variable "struct flow_block_offload *f" was added to
>> mlx5e_setup_tc() in recent rtnl lock removal patches. The variable is used
>> in code that is only compiled when CONFIG_MLX5_ESWITCH is enabled. This
>> results compilation warning about unused variable when CONFIG_MLX5_ESWITCH
>> is not set. Move the variable definition into eswitch-specific code block
>> from the begging of mlx5e_setup_tc() function.
>
>    Beginning?

Yep. Thanks for spotting it!

>
>> Fixes: c9f14470d048 ("net: sched: add API for registering unlocked offload block callbacks")
>> Reported-by: tanhuazhong <tanhuazhong@...wei.com>
>> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
> [...]
>
> MBR, Sergei