netdev - Re: linux-next: Tree for Aug 29 (mlx5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82c4fad3fc394693a596597df0d73cc5235f7025.camel@mellanox.com>
Date:   Thu, 29 Aug 2019 23:04:09 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        haiyangz <haiyangz@...rosoft.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: linux-next: Tree for Aug 29 (mlx5)

On Thu, 2019-08-29 at 21:48 +0000, Haiyang Zhang wrote:
> > -----Original Message-----
> > From: Saeed Mahameed <saeedm@...lanox.com>
> > Sent: Thursday, August 29, 2019 2:32 PM
> > To: sfr@...b.auug.org.au; Eran Ben Elisha <eranbe@...lanox.com>;
> > linux-
> > next@...r.kernel.org; rdunlap@...radead.org; Haiyang Zhang
> > <haiyangz@...rosoft.com>
> > Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; Leon
> > Romanovsky <leonro@...lanox.com>
> > Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> > 
> > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > > 
> > > > > Changes since 20190828:
> > > > > 
> > > > 
> > > > on x86_64:
> > > > when CONFIG_PCI_HYPERV=m
> > > 
> > > and CONFIG_PCI_HYPERV_INTERFACE=m
> > > 
> > 
> > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> > supposed to be a module ? it supposed to provide an always
> > available
> > interface to drivers ..
> > 
> > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.
> 
> The symbolic dependency by driver mlx5e,  automatically triggers
> loading of
> pci_hyperv_interface module. And this module can be loaded in any
> platforms.
> 

This only works when both are modules. 


> Currently, mlx5e driver has #if
> IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
> around the code using the interface.
> 
> I agree --
> Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these
> #if's.
> 

No, not "select", "imply".

if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you.

> Thanks,
> - Haiyang