| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190829064515.2751440-1-yhs@fb.com>
Date: Wed, 28 Aug 2019 23:45:15 -0700
From: Yonghong Song <yhs@...com>
To: <bpf@...r.kernel.org>, <netdev@...r.kernel.org>
CC: Alexei Starovoitov <ast@...com>,
Brian Vazquez <brianvv@...gle.com>,
Daniel Borkmann <daniel@...earbox.net>, <kernel-team@...com>,
Yonghong Song <yhs@...com>
Subject: [PATCH bpf-next 11/13] tools/bpf: add test for bpf_map_delete_batch()
Test bpf_map_delete_batch() functionality.
$ ./test_maps
...
test_map_delete_batch:PASS
...
---
.../bpf/map_tests/map_delete_batch.c | 139 ++++++++++++++++++
1 file changed, 139 insertions(+)
create mode 100644 tools/testing/selftests/bpf/map_tests/map_delete_batch.c
diff --git a/tools/testing/selftests/bpf/map_tests/map_delete_batch.c b/tools/testing/selftests/bpf/map_tests/map_delete_batch.c
new file mode 100644
index 000000000000..459495a6d9fc
--- /dev/null
+++ b/tools/testing/selftests/bpf/map_tests/map_delete_batch.c
@@ -0,0 +1,139 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2019 Facebook */
+#include <stdio.h>
+#include <errno.h>
+#include <string.h>
+
+#include <bpf/bpf.h>
+#include <bpf/libbpf.h>
+
+#include <test_maps.h>
+
+static void map_batch_update(int map_fd, __u32 max_entries, int *keys,
+ int *values)
+{
+ int i, err;
+
+ for (i = 0; i < max_entries; i++) {
+ keys[i] = i + 1;
+ values[i] = i + 2;
+ }
+
+ err = bpf_map_update_batch(map_fd, keys, values, &max_entries, 0, 0);
+ CHECK(err, "bpf_map_update_batch()", "error:%s\n", strerror(errno));
+}
+
+void test_map_delete_batch(void)
+{
+ struct bpf_create_map_attr xattr = {
+ .name = "hash_map",
+ .map_type = BPF_MAP_TYPE_HASH,
+ .key_size = sizeof(int),
+ .value_size = sizeof(int),
+ };
+ int map_fd, *keys, *values, *visited, key;
+ const __u32 max_entries = 10;
+ void *p_skey, *p_next_skey;
+ __u32 count, total;
+ int err, i, step;
+
+ xattr.max_entries = max_entries;
+ map_fd = bpf_create_map_xattr(&xattr);
+ CHECK(map_fd == -1,
+ "bpf_create_map_xattr()", "error:%s\n", strerror(errno));
+
+ keys = malloc(max_entries * sizeof(int));
+ values = malloc(max_entries * sizeof(int));
+ visited = malloc(max_entries * sizeof(int));
+ CHECK(!keys || !values || !visited, "malloc()", "error:%s\n", strerror(errno));
+
+ /* test 1: delete an empty hash table, success */
+ for (i = 0; i < 2; i++) {
+ if (i == 0) {
+ count = 0;
+ p_next_skey = NULL;
+ } else {
+ count = max_entries;
+ p_next_skey = &key;
+ }
+ err = bpf_map_delete_batch(map_fd, NULL, &p_next_skey, keys,
+ &count, 0, 0);
+ CHECK(err, "empty map", "error: %s\n", strerror(errno));
+ CHECK(p_next_skey || count, "empty map",
+ "i = %d, p_next_skey = %p, count = %u\n", i, p_next_skey,
+ count);
+ }
+
+ /* test 2: delete with count = 0, success */
+ for (i = 0; i < 2; i++) {
+ /* populate elements to the map */
+ map_batch_update(map_fd, max_entries, keys, values);
+
+ count = 0;
+ if (i == 0) {
+ /* all elements in the map */
+ p_skey = NULL;
+ } else {
+ /* all elements starting from p_skey */
+ p_skey = &key;
+ err = bpf_map_get_next_key(map_fd, NULL, p_skey);
+ CHECK(err, "bpf_map_get_next_key()", "error: %s\n",
+ strerror(errno));
+ }
+ err = bpf_map_delete_batch(map_fd, p_skey, NULL, NULL,
+ &count, 0, 0);
+ CHECK(err, "count = 0", "error: %s\n", strerror(errno));
+ /* all elements should be gone. */
+ err = bpf_map_get_next_key(map_fd, NULL, &key);
+ CHECK(!err, "bpf_map_get_next_key()", "unexpected success\n");
+ }
+
+ /* test 3: delete in a loop with various steps. */
+ for (step = 1; step < max_entries; step++) {
+ map_batch_update(map_fd, max_entries, keys, values);
+ memset(keys, 0, max_entries * sizeof(*keys));
+ memset(values, 0, max_entries * sizeof(*values));
+ p_skey = NULL;
+ p_next_skey = &key;
+ total = 0;
+ i = 0;
+ /* iteratively delete elements with 'step' elements each */
+ count = step;
+ while (true) {
+ err = bpf_map_delete_batch(map_fd, p_skey, &p_next_skey,
+ keys + i * step, &count, 0, 0);
+ CHECK(err, "delete with steps", "error: %s\n",
+ strerror(errno));
+
+ total += count;
+ if (!p_next_skey)
+ break;
+
+ CHECK(count != step, "delete with steps",
+ "i = %d, count = %u, step = %d\n",
+ i, count, step);
+
+ if (!p_skey)
+ p_skey = p_next_skey;
+ i++;
+ }
+
+ CHECK(total != max_entries, "delete with steps",
+ "total = %u, max_entries = %u\n", total, max_entries);
+
+ err = bpf_map_get_next_key(map_fd, NULL, &key);
+ CHECK(!err, "bpf_map_get_next_key()", "error: %s\n",
+ strerror(errno));
+ }
+
+ /* test 4: delete with keys in keys[]. */
+ map_batch_update(map_fd, max_entries, keys, values);
+ memset(values, 0, max_entries * sizeof(*values));
+ count = max_entries;
+ err = bpf_map_delete_batch(map_fd, NULL, NULL, keys, &count, 0, 0);
+ CHECK(err, "delete key in keys[]", "error: %s\n", strerror(errno));
+ err = bpf_map_get_next_key(map_fd, NULL, &key);
+ CHECK(!err, "bpf_map_get_next_key()", "error: %s\n", strerror(errno));
+
+ printf("%s:PASS\n", __func__);
+}
--
2.17.1
Powered by blists - more mailing lists