netdev - Re: [PATCH bpf-next 2/3] tools: bpftool: improve and check builds for different make invocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f127330-4395-92c8-a18e-3ac4ff80050b@netronome.com>
Date:   Fri, 30 Aug 2019 11:58:25 +0100
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Ilya Leoshkevich <iii@...ux.ibm.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Lorenz Bauer <lmb@...udflare.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH bpf-next 2/3] tools: bpftool: improve and check builds for
 different make invocations

2019-08-29 18:03 UTC+0200 ~ Ilya Leoshkevich <iii@...ux.ibm.com>
>> Am 29.08.2019 um 12:56 schrieb Quentin Monnet <quentin.monnet@...ronome.com>:
>>
>> +make_and_clean() {
>> +	echo -e "\$PWD:    $PWD"
>> +	echo -e "command: make -s $* >/dev/null"
>> +	make $J -s $* >/dev/null
> 
> Would it make sense to set ERROR=1 if make produces a bpftool binary,
> but still fails with a non-zero RC for whatever reason?
> 

Hi Ilya,

Generating bpftool being the last thing the Makefile does, I don't know
if this could happen. But sure, that wouldn't hurt, and I will add it to
v2, thanks!

Quentin