netdev - Re: [PATCH] sky2: Disable MSI on yet another ASUS boards (P6Xxxx)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190830.141812.1556491500124919572.davem@davemloft.net>
Date:   Fri, 30 Aug 2019 14:18:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tiwai@...e.de
Cc:     mlindner@...vell.com, stephen@...workplumber.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org, swm@...1.com
Subject: Re: [PATCH] sky2: Disable MSI on yet another ASUS boards (P6Xxxx)

From: Takashi Iwai <tiwai@...e.de>
Date: Thu, 29 Aug 2019 07:20:44 +0200

> On Thu, 29 Aug 2019 01:09:37 +0200,
> David Miller wrote:
>> 
>> From: Takashi Iwai <tiwai@...e.de>
>> Date: Wed, 28 Aug 2019 08:31:19 +0200
>> 
>> > A similar workaround for the suspend/resume problem is needed for yet
>> > another ASUS machines, P6X models.  Like the previous fix, the BIOS
>> > doesn't provide the standard DMI_SYS_* entry, so again DMI_BOARD_*
>> > entries are used instead.
>> > 
>> > Reported-and-tested-by: SteveM <swm@...1.com>
>> > Signed-off-by: Takashi Iwai <tiwai@...e.de>
>> 
>> Applied, but this is getting suspicious.
>> 
>> It looks like MSI generally is not restored properly on resume on these
>> boards, so maybe there simply needs to be a generic PCI quirk for that?
> 
> Yes, I wondered that, too.
> But, e.g. HD-audio should use MSI on Intel platforms, and if the
> problem were generic, it must suffer from the same issue, and I
> haven't heard of such, so far.  So it's likely specific to some
> limited devices, as it seems.

There must be some state of MSI state on the sky2 chip that is restored by
most BIOS/chipsets but not this one.

Some part of PCI config space or something.