netdev - RE: [PATCH] ncsi-netlink: support sending NC-SI commands over Netlink interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Aug 2019 21:46:05 +0000
From:   Ben Wei <benwei@...com>
To:     Terry Duncan <terry.s.duncan@...ux.intel.com>,
        "sam@...dozajonas.com" <sam@...dozajonas.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "Justin.Lee1@...l.com" <Justin.Lee1@...l.com>
Subject: RE: [PATCH] ncsi-netlink: support sending NC-SI commands over Netlink
 interface

> On 8/22/19 5:02 PM, Ben Wei wrote:
> > This patch extends ncsi-netlink command line utility to send NC-SI command to kernel driver
> > via NCSI_CMD_SEND_CMD command.
> > 
> > New command line option -o (opcode) is used to specify NC-SI command and optional payload.
> > 
>
> Thank you for posting this Ben.
> Something looks off on this next line but it looks fine in your pull 
> request in the github.com/sammj/ncsi-netlink repo.
>
> > +static int send_cb(struct nl_msg *msg, void *arg) { #define
> > +ETHERNET_HEADER_SIZE 16
> > +

Yes I think my email client was not configured correctly for plain text so it's removing certain line breaks.
Hopefully I have this figured out now so my future patches won't have this issue.

>
> Do you have plans to upstream your yocto recipe for this repo?

Yes I sure can upstream the recipe file. I had to make local changes to build ncsi-netlink for my BMC platform.
Is there a group I may submit my recipe to? 

Thanks,
-Ben