netdev - Re: [PATCH v6 net-next 15/19] ionic: Add Tx and Rx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190830152123.6307fee1@cakuba.netronome.com>
Date:   Fri, 30 Aug 2019 15:21:23 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v6 net-next 15/19] ionic: Add Tx and Rx handling

On Fri, 30 Aug 2019 14:44:24 -0700, Shannon Nelson wrote:
> On 8/29/19 4:33 PM, Jakub Kicinski wrote:
> > On Thu, 29 Aug 2019 11:27:16 -0700, Shannon Nelson wrote:  
>  [...]  
> > There's definitely a function for helping drivers which can't do full
> > TSO slice up the packet, but I can't find it now 😫😫
> >
> > Eric would definitely know.
> >
> > Did you have a look? Would it be useful here?  
> 
> Yes, obviously this could use some work for clarity and supportability, 
> and I think for performance as well.  But since it works, I've been 
> concentrating on getting other parts of the driver working before coming 
> back to this.  If there are some tools that can help clean this up, I 
> would be interested to see them.

Ha! I think I found it, can you take a look at net/core/tso.c and see
if any of those help?

I'm not opposed to merging as is, but at the same time I'm not
volunteering to review that function..