netdev - Re: [PATCH bpf-next 0/2] nfp: bpf: add simple map op cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <054e3384-c36a-5338-2de2-4dd92ba9e9fc@iogearbox.net>
Date:   Sat, 31 Aug 2019 01:23:14 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        jaco.gericke@...ronome.com
Subject: Re: [PATCH bpf-next 0/2] nfp: bpf: add simple map op cache

On 8/28/19 7:36 AM, Jakub Kicinski wrote:
> Hi!
> 
> This set adds a small batching and cache mechanism to the driver.
> Map dumps require two operations per element - get next, and
> lookup. Each of those needs a round trip to the device, and on
> a loaded system scheduling out and in of the dumping process.
> This set makes the driver request a number of entries at the same
> time, and if no operation which would modify the map happens
> from the host side those entries are used to serve lookup
> requests for up to 250us, at which point they are considered
> stale.
> 
> This set has been measured to provide almost 4x dumping speed
> improvement, Jaco says:
> 
> OLD dump times
>      500 000 elements: 26.1s
>        1 000 000 elements: 54.5s
> 
> NEW dump times
>      500 000 elements: 7.6s
>        1 000 000 elements: 16.5s
> 
> Jakub Kicinski (2):
>    nfp: bpf: rework MTU checking
>    nfp: bpf: add simple map op cache
> 
>   drivers/net/ethernet/netronome/nfp/bpf/cmsg.c | 187 ++++++++++++++++--
>   drivers/net/ethernet/netronome/nfp/bpf/fw.h   |   1 +
>   drivers/net/ethernet/netronome/nfp/bpf/main.c |  33 ++++
>   drivers/net/ethernet/netronome/nfp/bpf/main.h |  24 +++
>   .../net/ethernet/netronome/nfp/bpf/offload.c  |   3 +
>   drivers/net/ethernet/netronome/nfp/nfp_net.h  |   2 +-
>   .../ethernet/netronome/nfp/nfp_net_common.c   |   9 +-
>   7 files changed, 239 insertions(+), 20 deletions(-)

Applied, thanks!