netdev - Re: [PATCH] net: spider_net: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190829.175425.1248230437028888792.davem@davemloft.net>
Date:   Thu, 29 Aug 2019 17:54:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     kou.ishizaki@...hiba.co.jp, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: spider_net: Use struct_size() helper

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Wed, 28 Aug 2019 15:21:08 -0500

> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> 
> struct spider_net_card {
> 	...
>         struct spider_net_descr darray[0];
> };
> 
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
> 
> So, replace the following form:
> 
> sizeof(struct spider_net_card) + (tx_descriptors + rx_descriptors) * sizeof(struct spider_net_descr)
> 
> with:
> 
> struct_size(card, darray, tx_descriptors + rx_descriptors)
> 
> Notice that, in this case, variable alloc_size is not necessary, hence it
> is removed.
> 
> Building: allmodconfig powerpc.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied to net-next, thanks.