netdev - Re: iproute2: tc: potential buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190831083751.3814ee37@hermes.lan>
Date:   Sat, 31 Aug 2019 08:37:51 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     <tomaspaukrt@...il.cz>
Cc:     <netdev@...r.kernel.org>
Subject: Re: iproute2: tc: potential buffer overflow

On Sat, 31 Aug 2019 15:13:27 +0200 (CEST)
<tomaspaukrt@...il.cz> wrote:

> Hi,
> 
> there are two potentially dangerous calls of strcpy function in the program "tc". In the attachment is a patch that fixes this issue.
> 
> Tomas

This looks correct.

Please fix with strlcpy() instead; that is clearer.
Plus you can use XT_EXTENSION_MAX_NAMELEN here (optional).