netdev - Re: [PATCH net-next] net_failover: get rid of the limitaion receive packet from standy dev when primary exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190902.114251.1327692999568460655.davem@davemloft.net>
Date:   Mon, 02 Sep 2019 11:42:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenxu@...oud.cn
Cc:     sridhar.samudrala@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net_failover: get rid of the limitaion
 receive packet from standy dev when primary exist

From: wenxu@...oud.cn
Date: Fri, 30 Aug 2019 13:07:48 +0800

> From: wenxu <wenxu@...oud.cn>
> 
> For receive side the standby, primary and failover is the same one,
> If the packet receive from standby or primary should can be deliver
> to failover dev.
> 
> For example: there are VF and virtio device failover together.
> When live migration the VF detached and send/recv packet through
> virtio device. When VF attached again some ingress traffic may
> receive from virtio device for cache reason(TC flower offload in
> sw mode).
> 
> Signed-off-by: wenxu <wenxu@...oud.cn>

I don't understand, the device logic guarding the device rewriting in
this handler looks very much intentional.

After your changes we have no logic at all, we just unconditionally
always rewrite.