netdev - Re: [PATCH] net: stmmac: dwmac-sun8i: Variable "val" in function sun8i_dwmac_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190902.114836.1043194833851564994.davem@davemloft.net>
Date:   Mon, 02 Sep 2019 11:48:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yzhai003@....edu
Cc:     csong@...ucr.edu, zhiyunq@...ucr.edu, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com, mripard@...nel.org,
        wens@...e.org, mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized

From: Yizhuo <yzhai003@....edu>
Date: Fri, 30 Aug 2019 19:00:48 -0700

> In function sun8i_dwmac_set_syscon(), local variable "val" could
> be uninitialized if function regmap_field_read() returns -EINVAL.
> However, it will be used directly in the if statement, which
> is potentially unsafe.
> 
> Signed-off-by: Yizhuo <yzhai003@....edu>

Applied, thank you.