netdev - Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Sep 2019 12:46:01 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Moritz Fischer <mdf@...nel.org>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux-kernel@...r.kernel.org,
        davem@...emloft.net
Subject: Re: [PATCH] net: fixed_phy: Add forward declaration for struct
 gpio_desc;

On 9/3/19 11:46 AM, Moritz Fischer wrote:
> Add forward declaration for struct gpio_desc in order to address
> the following:
> 
> ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
> ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
> 
> Fixes commit 71bd106d2567 ("net: fixed-phy: Add
> fixed_phy_register_with_gpiod() API")

There is a standardized tag for that which is:

Fixes: 71bd106d2567 ("net: fixed-phy: Add
fixed_phy_register_with_gpiod() API")

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> Signed-off-by: Moritz Fischer <mdf@...nel.org>
> ---
>  include/linux/phy_fixed.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> index 1e5d86ebdaeb..52bc8e487ef7 100644
> --- a/include/linux/phy_fixed.h
> +++ b/include/linux/phy_fixed.h
> @@ -11,6 +11,7 @@ struct fixed_phy_status {
>  };
>  
>  struct device_node;
> +struct gpio_desc;
>  
>  #if IS_ENABLED(CONFIG_FIXED_PHY)
>  extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
> 


-- 
Florian