netdev - Re: [PATCH net-next 0/5] net/tls: minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Sep 2019 06:56:33 +0000
From:   Boris Pismenny <borisp@...lanox.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "davejwatson@...com" <davejwatson@...com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>
Subject: Re: [PATCH net-next 0/5] net/tls: minor cleanups

On 9/3/2019 7:31 AM, Jakub Kicinski wrote:
> Hi!
>
> This set is a grab bag of TLS cleanups accumulated in my tree
> in an attempt to avoid merge problems with net. Nothing stands
> out. First patch dedups context information. Next control path
> locking is very slightly optimized. Fourth patch cleans up
> ugly #ifdefs.
>
> Jakub Kicinski (5):
>   net/tls: use the full sk_proto pointer
>   net/tls: don't jump to return
>   net/tls: narrow down the critical area of device_offload_lock
>   net/tls: clean up the number of #ifdefs for CONFIG_TLS_DEVICE
>   net/tls: dedup the record cleanup
>
>  drivers/crypto/chelsio/chtls/chtls_main.c |  6 +-
>  include/net/tls.h                         | 48 +++++++++-----
>  net/tls/tls_device.c                      | 78 +++++++++++------------
>  net/tls/tls_main.c                        | 46 ++++---------
>  net/tls/tls_sw.c                          |  6 +-
>  5 files changed, 85 insertions(+), 99 deletions(-)

LGTM

Reviewed-by: Boris Pismenny <borisp@...lanox.com>