netdev - Re: [PATCH] hostap: remove set but not used variable 'copied' in prism2_io_debug_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5D6E1DF2.1000109@huawei.com>
Date:   Tue, 3 Sep 2019 16:01:54 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     zhong jiang <zhongjiang@...wei.com>
CC:     <kvalo@...eaurora.org>, <davem@...emloft.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hostap: remove set but not used variable 'copied' in
 prism2_io_debug_proc_read

Please ignore the patch.  Because  the hostap_proc.c is marked as 'obsolete'.

Thanks,
zhong jiang
On 2019/9/3 15:57, zhong jiang wrote:
> Obviously, variable 'copied' is initialized to zero. But it is not used.
> hence just remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/net/wireless/intersil/hostap/hostap_proc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intersil/hostap/hostap_proc.c b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> index 703d74c..6151d8d 100644
> --- a/drivers/net/wireless/intersil/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/intersil/hostap/hostap_proc.c
> @@ -234,7 +234,7 @@ static int prism2_io_debug_proc_read(char *page, char **start, off_t off,
>  {
>  	local_info_t *local = (local_info_t *) data;
>  	int head = local->io_debug_head;
> -	int start_bytes, left, copy, copied;
> +	int start_bytes, left, copy;
>  
>  	if (off + count > PRISM2_IO_DEBUG_SIZE * 4) {
>  		*eof = 1;
> @@ -243,7 +243,6 @@ static int prism2_io_debug_proc_read(char *page, char **start, off_t off,
>  		count = PRISM2_IO_DEBUG_SIZE * 4 - off;
>  	}
>  
> -	copied = 0;
>  	start_bytes = (PRISM2_IO_DEBUG_SIZE - head) * 4;
>  	left = count;
>