netdev - Re: net: hsr: remove a redundant null check before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce4f53c1-fd91-af5b-7f0a-4746c3ad8de1@web.de>
Date:   Wed, 4 Sep 2019 13:55:54 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     zhong jiang <zhongjiang@...wei.com>,
        Arvid Brodin <arvid.brodin@...en.se>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: net: hsr: remove a redundant null check before kfree_skb

> kfree_skb has taken the null pointer into account.

I suggest to take another look also at information around
a similar update suggestion.

net-hsr: Delete unnecessary checks before the function call "kfree_skb"
https://lkml.org/lkml/2015/11/14/120
https://lore.kernel.org/patchwork/patch/617878/
https://lore.kernel.org/r/5647A77E.6040501@users.sourceforge.net/

https://lkml.org/lkml/2015/11/24/433
https://lore.kernel.org/r/56546951.9080101@alten.se/

Regards,
Markus