netdev - Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Sep 2019 10:48:01 +0800
From:   Zhu Yanjun <yanjun.zhu@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv
 statistics


On 2019/9/5 6:22, David Miller wrote:
> From: Zhu Yanjun <yanjun.zhu@...cle.com>
> Date: Sun,  1 Sep 2019 03:26:13 -0400
>
>> +static inline void nv_get_stats(int cpu, struct fe_priv *np,
>> +				struct rtnl_link_stats64 *storage)
>   ...
>> +static inline void rx_missing_handler(u32 flags, struct fe_priv *np)
>> +{
> Never use the inline keyword in foo.c files, let the compiler decide.

Thanks a lot for your advice. I will pay attention to the usage of 
inline in the

source code.

If you agree, I will send V3 about this soon.

Zhu Yanjun

>