netdev - Re: rtnl_lock() question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FFDA0C01-0608-4A4A-B612-8964287D8E0A@intel.com>
Date:   Thu, 5 Sep 2019 18:07:43 +0000
From:   "Rustad, Mark D" <mark.d.rustad@...el.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
CC:     "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: rtnl_lock() question

On Sep 4, 2019, at 4:23 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:

> some allocations require parameters that should remain valid and
> constant across the whole reconfiguration procedure such
> params.num_channels, so they must be done inside the lock.

You could always check if those parameters have changed once under the lock  
and, if they did, drop the lock, reallocate and try again. Since such  
changes should be very infrequent, this is something that really should not  
loop multiple times.

--
Mark Rustad, Networking Division, Intel Corporation

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)