netdev - Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Sep 2019 22:21:49 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Luke Hsiao <lukehsiao@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

On Thu, Sep 5, 2019 at 10:20 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> tcp_diag_get_aux_size() can be called with sockets in any state.
>
> icsk_ulp_ops is only present for full sockets.
>
> For SYN_RECV or TIME_WAIT ones we would access garbage.
>
> Fixes: 61723b393292 ("tcp: ulp: add functions to dump ulp-specific information")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Luke Hsiao <lukehsiao@...gle.com>
> Reported-by: Neal Cardwell <ncardwell@...gle.com>
> Cc: Davide Caratti <dcaratti@...hat.com>
> ---

Sorry for the 'net' tag. This patch targets net-next tree only.