netdev - Re: [net PATCH] net: sock_map, fix missing ulp check in sock hash case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190905.115705.2055196374824241901.davem@davemloft.net>
Date:   Thu, 05 Sep 2019 11:57:05 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     john.fastabend@...il.com
Cc:     hdanton@...a.com, jakub.kicinski@...ronome.com,
        netdev@...r.kernel.org
Subject: Re: [net PATCH] net: sock_map, fix missing ulp check in sock hash
 case

From: John Fastabend <john.fastabend@...il.com>
Date: Tue, 03 Sep 2019 13:24:50 -0700

> sock_map and ULP only work together when ULP is loaded after the sock
> map is loaded. In the sock_map case we added a check for this to fail
> the load if ULP is already set. However, we missed the check on the
> sock_hash side.
> 
> Add a ULP check to the sock_hash update path.
> 
> Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
> Reported-by: syzbot+7a6ee4d0078eac6bf782@...kaller.appspotmail.com
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Applied and queued up for -stable, thanks.