netdev - Re: [PATCH v3 net] net: Properly update v4 routes with v6 nexthop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190905.123615.989515327771345755.davem@davemloft.net>
Date:   Thu, 05 Sep 2019 12:36:15 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     sharpd@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, dsahern@...nel.org,
        sworley@...ulusnetworks.com
Subject: Re: [PATCH v3 net] net: Properly update v4 routes with v6 nexthop

From: Donald Sharp <sharpd@...ulusnetworks.com>
Date: Wed,  4 Sep 2019 10:11:58 -0400

> When creating a v4 route that uses a v6 nexthop from a nexthop group.
> Allow the kernel to properly send the nexthop as v6 via the RTA_VIA
> attribute.
> 
> Broken behavior:
> 
> $ ip nexthop add via fe80::9 dev eth0
> $ ip nexthop show
> id 1 via fe80::9 dev eth0 scope link
> $ ip route add 4.5.6.7/32 nhid 1
> $ ip route show
> default via 10.0.2.2 dev eth0
> 4.5.6.7 nhid 1 via 254.128.0.0 dev eth0
> 10.0.2.0/24 dev eth0 proto kernel scope link src 10.0.2.15
> $
> 
> Fixed behavior:
> 
> $ ip nexthop add via fe80::9 dev eth0
> $ ip nexthop show
> id 1 via fe80::9 dev eth0 scope link
> $ ip route add 4.5.6.7/32 nhid 1
> $ ip route show
> default via 10.0.2.2 dev eth0
> 4.5.6.7 nhid 1 via inet6 fe80::9 dev eth0
> 10.0.2.0/24 dev eth0 proto kernel scope link src 10.0.2.15
> $
> 
> v2, v3: Addresses code review comments from David Ahern
> 
> Fixes: dcb1ecb50edf (“ipv4: Prepare for fib6_nh from a nexthop object”)
> Signed-off-by: Donald Sharp <sharpd@...ulusnetworks.com>

Applied, thank you.