lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Sep 2019 15:57:23 +0200 From: Marcel Holtmann <marcel@...tmann.org> To: Jiri Kosina <jikos@...nel.org> Cc: Dan Elkouby <streetwalkermc@...il.com>, Dan Carpenter <dan.carpenter@...cle.com>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, Brian Norris <computersforpeace@...il.com>, Fabian Henneke <fabian.henneke@...il.com>, Al Viro <viro@...iv.linux.org.uk>, Andrea Parri <andrea.parri@...rulasolutions.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message Hi Jiri, >> hidp_send_message was changed to return non-zero values on success, >> which some other bits did not expect. This caused spurious errors to be >> propagated through the stack, breaking some drivers, such as hid-sony >> for the Dualshock 4 in Bluetooth mode. >> >> As pointed out by Dan Carpenter, hid-microsoft directly relied on that >> assumption as well. >> >> Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes") >> >> Signed-off-by: Dan Elkouby <streetwalkermc@...il.com> > > Reviewed-by: Jiri Kosina <jkosina@...e.cz> > > Marcel, are you taking this through your tree? I am taking this through my tree. And yes, I applied the updated patch, but answered the other ;) Regards Marcel
Powered by blists - more mailing lists