netdev - Re: [net-next 02/11] devlink: add 'reset_dev_on_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8066ba35-2f9b-c175-100f-e754b4ca65be@netronome.com>
Date:   Fri, 6 Sep 2019 11:40:54 -0700
From:   Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>,
        Simon Horman <simon.horman@...ronome.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [net-next 02/11] devlink: add 'reset_dev_on_drv_probe' param


On 9/6/19 11:31 AM, Jiri Pirko wrote:
> Fri, Sep 06, 2019 at 06:00:52PM CEST, simon.horman@...ronome.com wrote:
>> From: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
>>
>> Add the 'reset_dev_on_drv_probe' devlink parameter, controlling the
>> device reset policy on driver probe.
>>
>> This parameter is useful in conjunction with the existing
>> 'fw_load_policy' parameter.
>>
>> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
>> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
>> ---
>> Documentation/networking/devlink-params.txt | 14 ++++++++++++++
>> include/net/devlink.h                       |  4 ++++
>> include/uapi/linux/devlink.h                |  7 +++++++
>> net/core/devlink.c                          |  5 +++++
>> 4 files changed, 30 insertions(+)
>>
>> diff --git a/Documentation/networking/devlink-params.txt b/Documentation/networking/devlink-params.txt
>> index fadb5436188d..f9e30d686243 100644
>> --- a/Documentation/networking/devlink-params.txt
>> +++ b/Documentation/networking/devlink-params.txt
>> @@ -51,3 +51,17 @@ fw_load_policy		[DEVICE, GENERIC]
>> 			* DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DISK (2)
>> 			  Load firmware currently available on host's disk.
>> 			Type: u8
>> +
>> +reset_dev_on_drv_probe	[DEVICE, GENERIC]
>> +			Controls the device's reset policy on driver probe.
>> +			Valid values:
>> +			* DEVLINK_PARAM_RESET_DEV_VALUE_UNKNOWN (0)
>> +			  Unknown or invalid value.
> Why do you need this? Do you have usecase for this value?


I added this in to avoid having the entire netlink dump fail when there 
are invalid values read from hardware.

This way, it can report an unknown or invalid value instead of failing 
the operation.


>
>
>> +			* DEVLINK_PARAM_RESET_DEV_VALUE_ALWAYS (1)
>> +			  Always reset device on driver probe.
>> +			* DEVLINK_PARAM_RESET_DEV_VALUE_NEVER (2)
>> +			  Never reset device on driver probe.
>> +			* DEVLINK_PARAM_RESET_DEV_VALUE_DISK (3)
>> +			  Reset only if device firmware can be found in the
>> +			  filesystem.
>> +			Type: u8
>> diff --git a/include/net/devlink.h b/include/net/devlink.h
>> index 460bc629d1a4..d880de5b8d3a 100644
>> --- a/include/net/devlink.h
>> +++ b/include/net/devlink.h
>> @@ -398,6 +398,7 @@ enum devlink_param_generic_id {
>> 	DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
>> 	DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
>> 	DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY,
>> +	DEVLINK_PARAM_GENERIC_ID_RESET_DEV,
>>
>> 	/* add new param generic ids above here*/
>> 	__DEVLINK_PARAM_GENERIC_ID_MAX,
>> @@ -428,6 +429,9 @@ enum devlink_param_generic_id {
>> #define DEVLINK_PARAM_GENERIC_FW_LOAD_POLICY_NAME "fw_load_policy"
>> #define DEVLINK_PARAM_GENERIC_FW_LOAD_POLICY_TYPE DEVLINK_PARAM_TYPE_U8
>>
>> +#define DEVLINK_PARAM_GENERIC_RESET_DEV_NAME "reset_dev_on_drv_probe"
> The name of the define and name of the string should be the same. Please
> adjust.


Sure, I will make the change.

Thanks for the review.