netdev - Re: [net-next 02/11] devlink: add 'reset_dev_on_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190907102853.GA25407@nanopsycho.orion>
Date:   Sat, 7 Sep 2019 12:28:53 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Dirk van der Merwe <dirk.vandermerwe@...ronome.com>,
        Simon Horman <simon.horman@...ronome.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [net-next 02/11] devlink: add 'reset_dev_on_drv_probe' param

Sat, Sep 07, 2019 at 06:17:30AM CEST, jakub.kicinski@...ronome.com wrote:
>On Fri, 6 Sep 2019 11:40:54 -0700, Dirk van der Merwe wrote:
>> >> DEVLINK_PARAM_RESET_DEV_VALUE_UNKNOWN (0)
>> >> +			  Unknown or invalid value.  
>> > Why do you need this? Do you have usecase for this value?  
>> 
>> I added this in to avoid having the entire netlink dump fail when there 
>> are invalid values read from hardware.
>> 
>> This way, it can report an unknown or invalid value instead of failing 
>> the operation.
>
>That's the first reason, the second is that we also want to report 
>the unknown value if it's not recognized by the driver. For u8/enum
>parameters the value may possibly be set to a value older driver
>doesn't understand, but users should still be able to set them to one
>of the known ones.

Ok.

>
>We'd also like to add that to 'fw_load_policy'. WDYT?

Ok.